Re: [Arm] SP and SL initialization refactored
Alexander Fedotov <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <CAN8C2CqEWQyXpjZ4Xw+bezz3A3M_N5S-ggSQxOx3qwbEa6haYA@mail.gmail.com> |
I've found a typo at the end of _stack_init routine: + b lr + FN_END must be + bx lr + FN_END I think we can fix this directly in the original patch before apply. Alex On Fri, Mar 29, 2019 at 10:03 PM Tamar Christina <[email protected]> wrote: > > Hi Alex, > > I'm not that familiar with CMSIS so I'll leave that part up to Richard, > But the rest of the patch looks good to me as well. > > Cheers, > Tamar > > > -----Original Message----- > > From: Nick Clifton <[email protected]> > > Sent: Tuesday, March 26, 2019 12:43 > > To: Alexander Fedotov <[email protected]>; Richard Earnshaw > > <[email protected]>; Tamar Christina > > <[email protected]>; Newlib <[email protected]> > > Cc: nd <[email protected]> > > Subject: Re: [Arm] SP and SL initialization refactored > > > > Hi Alex, > > > > > ping > > > > Sorry - I am not very involved with newlib these days, but I can say that the > > changes look reasonable to me. > > > > Cheers > > Nick > > > > > -- Best regards, AF