Re: [PATCH] Arm - exceptions stack pointer initialization hook

On 06/02/2019 13:12, Tamar Christina wrote:
> Hi Alex,
> 
> Yes, I made an ticket to go look at this, It doesn't have any of the THUMB changes either so it's way way out of date.
> But I need to wait for Richard to ask if they really should be exact copies.
> 
They should be practically identical.  The code in newlib is less
flexible in that you end up building it directly into newlib rather than
supporting multiple variants, but it should be doing the same thing in
all other respects.

It's unfortunate that the two have managed to get out of sync.

R.

> Cheersm
> Tamar
> 
>> -----Original Message-----
>> From: Alexander Fedotov <[email protected]>
>> Sent: Wednesday, February 6, 2019 12:49
>> To: Tamar Christina <[email protected]>
>> Cc: Newlib <[email protected]>; Richard Earnshaw
>> <[email protected]>; nd <[email protected]>
>> Subject: Re: [PATCH] Arm - exceptions stack pointer initialization hook
>>
>> Hi Tamar
>> Ok, I will update patches a bit later. It seems crt0.S in libgloss and libc aren't
>> up to sync long time. I don't see semihosting v2 changes there as well...
>> Alex
>>
>> On Wed, Feb 6, 2019 at 2:32 PM Tamar Christina <[email protected]>
>> wrote:
>>>
>>> Hi All,
>>>
>>> As a side note,
>>>
>>> As Richard mentioned any changes here should be mirrored to the
>> newlib/libc/sys/arm/* folder.
>>>
>>> Thanks,
>>> Tamar
>>>
>>>> -----Original Message-----
>>>> From: Tamar Christina
>>>> Sent: Tuesday, February 5, 2019 12:42
>>>> To: Alexander Fedotov <[email protected]>; Newlib
>>>> <[email protected]>; Richard Earnshaw
>> <[email protected]>
>>>> Cc: nd <[email protected]>
>>>> Subject: RE: [PATCH] Arm - exceptions stack pointer initialization
>>>> hook
>>>>
>>>> Hi all,
>>>>
>>>> This patch looks good to me as well (but I'm not a maintainer so
>>>> can't approve), It's mostly just refactoring, the only functional
>>>> change is that _exceptions_stack_init is now also called in the case
>>>> of semihosting, which I think is OK as well, but would like Richard to
>> quickly confirm.
>>>>
>>>> I'll run it by him when he's  back,
>>>>
>>>> Thanks,
>>>> Tamar
>>>>
>>>>> -----Original Message-----
>>>>> From: Alexander Fedotov <[email protected]>
>>>>> Sent: Tuesday, February 5, 2019 10:41
>>>>> To: Newlib <[email protected]>; Richard Earnshaw
>>>>> <[email protected]>; Tamar Christina
>>>> <[email protected]>;
>>>>> Alexander Fedotov <[email protected]>
>>>>> Subject: Re: [PATCH] Arm - exceptions stack pointer initialization
>>>>> hook
>>>>>
>>>>> Eventually I want to push all the changes from there:
>>>>> 1.
>>>>>
>>>>
>> https://github.com/alfedotov/newlib/commit/58ce6f19eb457a2c2b700dfe7
>>>> 1
>>>>> 798ef09ba63e10
>>>>> 2.
>>>>>
>>>>
>> https://github.com/alfedotov/newlib/commit/4cabb1f7587304d1c891da59b
>>>>> d1871fcc8668ae5
>>>>> 3.
>>>>>
>>>>
>> https://github.com/alfedotov/newlib/commit/7d38977d4baaecb43fc47f34d
>>>> 7
>>>>> 21a3df23334400
>>>>> 4.
>>>>>
>>>>
>> https://github.com/alfedotov/newlib/commit/e8f094f6729ade24a149d1d68
>>>> 1
>>>>> 6876e7ccadae0a
>>>>>
>>>>> General idea behind of all these changes is to provide hooks for
>>>>> flexibility (including semihosting when debug tap is used) and
>>>>> improve readability of existing crt0 code. At the moment it is a total
>> mess of ifdefs...
>>>>>
>>>>> Alex
>>>>>
>>>>> On Tue, Feb 5, 2019 at 1:32 PM Corinna Vinschen
>>>>> <[email protected]>
>>>>> wrote:
>>>>>>
>>>>>> On Feb  3 22:59, Alexander Fedotov wrote:
>>>>>>> Please find attached patch that adds new hook
>>>>>>> "_exceptions_stack_init". Hook is defined as "weak" to give
>>>>>>> user ability to override by it's own implementation.
>>>>>>> Also added new macro for .fnstart and .fnend to improve readability.
>>>>>>>
>>>>>>> Alex
>>>>>>
>>>>>> Any ARM person to review this patch and the patches from
>>>>>> https://sourceware.org/ml/newlib/2019/msg00028.html?
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Corinna
>>>>>>
>>>>>> --
>>>>>> Corinna Vinschen
>>>>>> Cygwin Maintainer
>>>>>> Red Hat
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best regards,
>>>>> AF
>>
>>
>>
>> --
>> Best regards,
>> AF