Re: [Arm] SP and SL initialization refactored

Corinna Vinschen <[email protected]> Wed, 10 Apr 2019 16:23:53 +0200

Newsgroups	gmane.comp.lib.newlib
Message-ID	<[email protected]>

Hi Richard,

On Apr 10 13:26, Richard Earnshaw (lists) wrote:
> On 19/03/2019 13:54, Alexander Fedotov wrote:
> > Hi all
> > 
> > In continue of threads
> > https://sourceware.org/ml/newlib/2019/msg00117.html and
> > https://sourceware.org/ml/newlib/2019/msg00102.html
> > 
> > I have reworked stack pointer initialization and stack limit as well.
> > General idea behind of all these changes is to provide hook for
> > flexibility (including semihosting when debug tap is used) and improve
> > readability of existing crt0 code.
> > And now code makes SP initialization in Thumb mode :)
> > 
> > Any comments are very appreciated.
> > 
> > Alex
> > 
> 
> Apologies once again for the delayed review.
> 
> A small plea: when posting patches, please can you ensure that your
> attachments are text/patch, or something similar, so that replies will
> include the contents (and I can view them directly in the email rather
> than having to mess about extracting the attachment).

Ideally the patches are inline patches sent with `git send-email' or
equivalent.  I added some wording in terms of how to provide patches to
https://sourceware.org/newlib/ lately.  Do you have a suggestion for
improving this?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

signature.asc (application/pgp-signature, 833 B)