Re: Cygwin: Implement sched_[gs]etaffinity() commit breaks RTEMS port
Sebastian Huber <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On 29/06/2019 02:57, Mark Geisert wrote: > Corinna Vinschen wrote: >> On Jun 28 10:06, Yaakov Selkowitz wrote: >>> On Fri, 2019-06-28 at 03:17 -0700, Mark Geisert wrote: >>>> We can call it a day, with review and release of the current patch >>>> state. >>>> If you think it's worthwhile to implement CPU_SET on Cygwin now, rather >>>> than later, I can look into it but it's not strictly necessary at this >>>> time. >>> >>> We shouldn't be do things half-way. taskset may not require it, but >>> any use of CPU sets could very well expect this to be present: >>> >>> http://man7.org/linux/man-pages/man3/CPU_SET.3.html >> >> Agreed. We shouldn't release 3.1 without it. > > Fair enough on the requirement. Just FYI I'll be AFK for two weeks > beginning July 4, so will try to get this done before I leave. No big > worry there. > > Please forgive my ignorance of licensing details... Are we allowed to > copy GNU library source into Cygwin? Or is re-implementation from > documentation the way to go? In either case, must the glibc file > organization be followed or is platform-specific rejiggering acceptable? > > I'd like to just add the CPU_SET macros to Cygwin's new sys/cpuset.h and > any needed support code to our sched.cc but am willing to hear other > options. It would be nice to have a common Newlib implementation which can be used for Cygwin, RTEMS and other systems. The RTEMS implementation is BSD licensed and uses the FreeBSD BITSET(9) support: https://www.freebsd.org/cgi/man.cgi?query=bitset&apropos=0&sektion=9 The goal of the RTEMS <sys/cpuset.h> is to provide the full glibc API http://man7.org/linux/man-pages/man3/CPU_SET.3.html and as much as possible from FreeBSD CPUSET(9) https://www.freebsd.org/cgi/man.cgi?query=cpuset&sektion=9&apropos=0 If you don't want the FreeBSD compatibility in Cygwin (it may confuse configure scripts), then we can move this to a separate part and only provide it by RTEMS. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : [email protected] PGP : Public key available on request. Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.