Re: [PATCH 2/2] fix compile errors for efgcvt.c

Corinna Vinschen <[email protected]> Wed, 24 Jul 2019 09:25:17 +0200

Newsgroups	gmane.comp.lib.newlib
Message-ID	<[email protected]>

On Jul 23 21:15, [email protected] wrote:
> From: uchan-nos <[email protected]>
> 
> ---
>  newlib/libc/stdlib/efgcvt.c | 33 ++++++++++++++++++---------------
>  1 file changed, 18 insertions(+), 15 deletions(-)
> 
> diff --git a/newlib/libc/stdlib/efgcvt.c b/newlib/libc/stdlib/efgcvt.c
> index 9314bf361..3cdb9c420 100644
> --- a/newlib/libc/stdlib/efgcvt.c
> +++ b/newlib/libc/stdlib/efgcvt.c
> @@ -102,6 +102,9 @@ Supporting OS subroutines required: <<close>>, <<fstat>>, <<isatty>>,
>  #include <stdlib.h>
>  #include "local.h"
>  
> +char *	ecvtbuf (double, int, int*, int*, char *);
> +char *	fcvtbuf (double, int, int*, int*, char *);
> +
>  char *
>  fcvt (double d,
>  	int ndigit,
> @@ -121,6 +124,21 @@ fcvtf (float d,
>  }
>  
>  
> +char *
> +gcvt (double d,
> +	int ndigit,
> +	char *buf)
> +{
> +  char *tbuf = buf;
> +  if (d < 0) {
> +    *buf = '-';
> +    buf++;
> +    ndigit--;
> +  }
> +  return (_gcvt (_REENT, d, ndigit, buf, 'g', 0) ? tbuf : 0);
> +}
> +
> +
>  char *
>  gcvtf (float d,
>  	int ndigit,
> @@ -148,18 +166,3 @@ ecvtf (float d,
>  {
>    return ecvt ((double) d, ndigit, decpt, sign);
>  }
> -
> -
> -char *
> -gcvt (double d,
> -	int ndigit,
> -	char *buf)
> -{
> -  char *tbuf = buf;
> -  if (d < 0) {
> -    *buf = '-';
> -    buf++;
> -    ndigit--;
> -  }
> -  return (_gcvt (_REENT, d, ndigit, buf, 'g', 0) ? tbuf : 0);
> -}
> -- 
> 2.17.1

Why does your patch arbitrarily move the gcvt function?  There's
no functional change, so this move should not be part of the patch.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

signature.asc (application/pgp-signature, 833 B)