Re: [PATCH 2/2] fix compile errors for efgcvt.c

On Jul 24 17:43, Kota Uchida wrote:
> On Wed, Jul 24, 2019 at 4:25 PM Corinna Vinschen <[email protected]> wrote:
> > Why does your patch arbitrarily move the gcvt function?  There's
> > no functional change, so this move should not be part of the patch.
> 
> The movement is the core of this patch.
> 
> When efgcvt.c is compiled under some specific conditions,
> gcvt's function prototype is NOT provided by stdlib.h.
> (Its prototype is gurded by macros)
> 
> If gcvt is below gcvtf, gcvt is implicitly declared as int
> since gcvtf calls gcvt.
> The implicit declaration is not compatible with its actual type.
> 
> So the possible options will be:
> - To move gcvt above gcvtf, or
> - To declare gcvt's prototype above gcvtf.
> 
> Should I choose 2nd option?

No, I pushed the patch.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl04LA0ACgkQ9TYGna5E
T6AYOBAAhORKBbSsPcqY5Q/E5EAV9qyEgLTrktR0c6VEUeoINLkfysiFEmu9SP04
RM0qbbQquI3TtP9vu5k7ZMUlmfL7TqQvz2fkER/O6Uz7+ut64jByaFaIjjZGJbq0
siY59kyDK3PL7Un3rsHMHXDwcXKQyKfwaQiqa9En0nwxYRl5IeFose64YydpvR1Z
MWypA/QwELqYd5oj5BBEZM5e69m7WkJPH0KeKGTKK4G2ZdQfivCdth6yWcuHCr3/
KnkNUg0diWenztuWnAFk5Ro6DVQ5wQC4JEIPGP+seTZrLNe5yVnn0KYBoOndVCba
CaJAW4ArW/kKJ7x/fXrhduVSD+9D2kfJ7VSVdOO/h2MwOZKkHPZ/soPzcAKMVMXy
dSTorFqBmhHojr3hgzN/5/Gk+VDLSPk1ai8W1JJVhlXQ7EujNJHncdsMTz0SMWOa
MTACPayUZvo68nNgD7MGU9dxssUZsPQL2XZzX/1L57ngw7LT0FFqXGbloYbS5kKr
RlkWoJpJ74ssunNASg9h3BAQkBdLmnldfv7Qx3oFcyrhJ/yABquorWTQ2N44sYFC
2nQ9heUHPX0V6g9YWlejx6cmRt/favbcU7IBmr6We7C4ghWC5pmWKjIDwGUqABjH
0KL30QoXZ8gZd8/zyXLsIGXms3qEzK5kLd3oC9Ddb9XZ817DzTs=
=2Z5j
-----END PGP SIGNATURE-----