Re: [PATCH v1] Port ndbm
Vaibhav Gupta <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <CAP+cEONs58Y2cs4scqRUpLaJ_bZOe-SfoM8SXDs_cG-TrZwrXQ@mail.gmail.com> |
On Thu, Jul 25, 2019, 1:48 AM Corinna Vinschen <[email protected]> wrote: > On Jul 24 09:22, Corinna Vinschen wrote: > > On Jul 10 14:25, Vaibhav Gupta wrote: > > > --- > > > newlib/libc/include/ndbm.h | 93 ++++++++++++++ > > > newlib/libc/search/Makefile.am | 1 + > > > newlib/libc/search/ndbm.c | 217 +++++++++++++++++++++++++++++++++ > > > 3 files changed, 311 insertions(+) > > > create mode 100644 newlib/libc/include/ndbm.h > > > create mode 100644 newlib/libc/search/ndbm.c > > > > Pushed. > > However, where's dbm_forder? It's declared in ndbm.h but there's no > such function in ndbm.c. > Both dbm_forder and dbm_dirinfo are wrapped inside __BSD_VISIBLE, although dbm_dirinfo is defined in ndbm.c but it will not be usable i guess. . I explored a bit, found that some features are for BSD systems and are not compatible with POSIX, Moreover dbm_forder and dbm_dirinfo are not mentioned in open group page. . I didn't planned to modify the contents much when i ported It from FreeBSD and hence they are present here. If required I can remove them and send a new patch. Vaibhav Gupta > > > Corinna > > -- > Corinna Vinschen > Cygwin Maintainer > Red Hat >