Re: [PATCH] common/math_errf.c: Enable compilation of __math_oflowf
Joel Sherrill <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <CAF9ehCV_hWkKC_8EFDfGEo+m7pXRo9+Er6jK5tj3SFdt0B+EwA@mail.gmail.com> |
On Mon, Jul 29, 2019 at 3:58 AM Corinna Vinschen <[email protected]> wrote: > On Jul 26 14:39, [email protected] wrote: > > From: Joel Sherrill <[email protected]> > > > > This resolved linking errors when using methods such as > > expm1(). > > --- > > newlib/libm/common/math_errf.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > Ok, please push. > Pushed. Thanks. It seems as though a set of tests which invoke a single method and just link (not execute) would have been sufficient to catch this. RTEMS has tests which ensure the signatures matches POSIX but they don't link to ensure all the supporting symbols are satisfied. Looks like something to put on the todo list. --joel > > > Thanks, > Corinna > > -- > Corinna Vinschen > Cygwin Maintainer > Red Hat >