Re: [PATCH v1 1/3] Reflect commits: 1. 8d98f95 (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=8d98f956cc398d086794e19051c3380d599022da) 2. 5c9403e (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=5c9403eaf40951f8a4f55ed65f661b485ff44be7)
Eric Blake <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On 7/31/19 11:38 AM, Alexander Fedotov wrote: Way too long for the subject line (which should ideally be less than 70 characters, and should be a one-line summary of what is changing), and missing a commit message body (that's where you can go into the details, including why the change is worthwhile, rather than just pointing to a URL). > --- > libgloss/arm/syscalls.c | 12 ++++++------ > newlib/libc/sys/arm/crt0.S | 7 +++++++ > newlib/libc/sys/arm/syscalls.c | 9 +++++++-- > 3 files changed, 20 insertions(+), 8 deletions(-) I should know what the patch is intended to do by the time I get to this point in the email, but "Reflect commits" with two URLs as an overly-long subject has failed to do that. Can you please resubmit with a better commit message? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl1BzDoACgkQp6FrSiUn Q2orTQgAjjUDt/skSVG4XGy22zP5Sk26rs/MlHAp5E3oAzVeylyJkP3HMQTtukSL StGOdXpw5drfr7LQ9xt1C8JjLvO3ku/EjAaFXM/lCKdNVl2meSqvCM4JSwc3fYDU 4pcCboDOjggS8w09PigucglByx4BVIJUdhiWbG3NpJHg2g3M8l41CDwD6r5DRrF5 Tq0qO8YjwPHQp9txIg46PWswsIObFrHnroXRMCyD+PL03xemX7dqZ3c0LnGfrP8R cCIkAznQLzjLsBBMWAcdzslvtGA7eulU9ewf/rvVofjibWCpLUJHSI5n50VMiBi6 9+3nmX37YWOv5DE0d61c6BI72IJ5Tg== =hj/f -----END PGP SIGNATURE-----