Re: riscv fenv.h header file guard typo

Kito Cheng <[email protected]>
Newsgroups gmane.comp.lib.newlib
Message-ID <CA+yXCZBhf3pK5M6Aquv9p3U3YLxNvomFjN-yF-dwAEbcWqYrMA@mail.gmail.com>
Hi Joel:

Thanks, I've send a patch for that :)

https://www.sourceware.org/ml/newlib/2019/msg00407.html

On Thu, Aug 1, 2019 at 7:13 AM Howland, Craig D. - US via newlib
<[email protected]> wrote:
>
>
> ________________________________________
> From: [email protected] <[email protected]> on behalf of Joel Sherrill <[email protected]>
> Sent: Wednesday, July 31, 2019 6:47 PM
> To: Newlib
> Subject: riscv fenv.h header file guard typo
>
> Hi
>
> While working on the proposed fenv.h infrastructure support, I noticed that
> the riscv fenv.h and sys/fenv.h appear to have very similar header guards
> (only a trailing _ differentiates them).
>
> /libc/machine/riscv/include/fenv.h:#ifndef _FENV_H
> ./libc/machine/riscv/sys/fenv.h:#ifndef _FENV_H_
>
> Would it be better for sys/fenv.h to have _SYS_FENV_H?
>
> --joel
>
> Yes, better.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.