Re: [PATCH v6 2/3] Add default implementation of fenv.h and all methods

Corinna Vinschen <[email protected]> Thu, 8 Aug 2019 21:05:23 +0200

Newsgroups	gmane.comp.lib.newlib
Message-ID	<[email protected]>

On Aug  8 11:27, [email protected] wrote:
> +/*
> + * This is a non-functional implementation that should be overridden
> + * by an architecture specific implementation in newlib/libm/machine/ARCH.
> + *
> + * The implmentation must defined FE_DFL_ENV to point to a default
> + * environment of type fenv_t.
> + */
> +static const fenv_t fe_dfl_env = { 0 };
> +const fenv_t *_fe_dfl_env = &fe_dfl_env;

Bummer.  This doesn't work.  The problem is that Cygwin needs to
initialize fe_dfl_env, like this:

  fegetenv (&fe_dfl_env);

However, even if I drop `const' as in Cygwin, if fe_dfl_env is static
I can't access it from the _feinitialise() function at DLL init time.

I'm not quite sure how to fix this.  Any ideas?  Do I have to drop
the idea to reuse this file and we need our own target-specific one?

Corinna

P.S.: Apart from this problem we can use this now.  We should just add
the GNU specific FE_NOMASK_ENV soon, too.

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

signature.asc (application/pgp-signature, 833 B)