Re: [PATCH 1/3] Fix fcvt to only show 'ndigit' past decimal

Corinna Vinschen <[email protected]> Wed, 18 Dec 2019 09:53:38 +0100

Newsgroups	gmane.comp.lib.newlib
Message-ID	<[email protected]>

Hi Keith,

On Dec 17 22:00, Keith Packard wrote:
> Even if the number is really small and this means showing *no* digits.
> This makes newlib match glibc, and the fcvt posix man page.
> 
> Signed-off-by: Keith Packard <[email protected]>
> ---
>  newlib/libc/stdlib/ecvtbuf.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/newlib/libc/stdlib/ecvtbuf.c b/newlib/libc/stdlib/ecvtbuf.c
> index e3d7b55d8..0a5d41a0f 100644
> --- a/newlib/libc/stdlib/ecvtbuf.c
> +++ b/newlib/libc/stdlib/ecvtbuf.c
> @@ -235,14 +235,7 @@ fcvtbuf (double invalue,
>  
>    save = fcvt_buf;
>  
> -  if (invalue < 1.0 && invalue > -1.0)
> -    {
> -      p = _dtoa_r (reent, invalue, 2, ndigit, decpt, sign, &end);
> -    }
> -  else
> -    {
> -      p = _dtoa_r (reent, invalue, 3, ndigit, decpt, sign, &end);
> -    }
> +  p = _dtoa_r (invalue, 3, ndigit, decpt, sign, &end);
                ^^^^^
There's a reent ptr missing in this call.  I'm puzzled that this
compiled for you.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

signature.asc (application/pgp-signature, 833 B)