Re: [PATCH v4] x86_64/i386 fenv: Replace symlink with include fenv_stub.c

Thank you for hanging in on this one.

--joel

On Tue, Feb 25, 2020 at 9:44 AM Corinna Vinschen <[email protected]>
wrote:

> On Feb 25 07:38, Joel Sherrill wrote:
> > Having symlinks for these files led to an issue reported to the RTEMS
> > Project that showed up using some tar for native Windows to unpack the
> > newlib sources.  It creates symlinks in the tar file as copies of the
> > files the symlinks point to.  If the links appear in the tar file before
> > the source exists, it cannot copy the file.
> >
> > The solution in this patch is to convert the files that are symbolic
> > links into simple files which include the file they were linked to.
> > This should be more portable and avoids the symbolinc link problem.
> > ---
> >  newlib/libm/machine/i386/feclearexcept.c     | 8 +++++++-
> >  newlib/libm/machine/i386/fegetenv.c          | 8 +++++++-
> >  newlib/libm/machine/i386/fegetexceptflag.c   | 8 +++++++-
> >  newlib/libm/machine/i386/fegetround.c        | 8 +++++++-
> >  newlib/libm/machine/i386/feholdexcept.c      | 8 +++++++-
> >  newlib/libm/machine/i386/fenv.c              | 8 +++++++-
> >  newlib/libm/machine/i386/feraiseexcept.c     | 8 +++++++-
> >  newlib/libm/machine/i386/fesetenv.c          | 8 +++++++-
> >  newlib/libm/machine/i386/fesetexceptflag.c   | 8 +++++++-
> >  newlib/libm/machine/i386/fesetround.c        | 8 +++++++-
> >  newlib/libm/machine/i386/fetestexcept.c      | 8 +++++++-
> >  newlib/libm/machine/i386/feupdateenv.c       | 8 +++++++-
> >  newlib/libm/machine/x86_64/feclearexcept.c   | 8 +++++++-
> >  newlib/libm/machine/x86_64/fegetenv.c        | 8 +++++++-
> >  newlib/libm/machine/x86_64/fegetexceptflag.c | 8 +++++++-
> >  newlib/libm/machine/x86_64/fegetround.c      | 8 +++++++-
> >  newlib/libm/machine/x86_64/feholdexcept.c    | 8 +++++++-
> >  newlib/libm/machine/x86_64/feraiseexcept.c   | 8 +++++++-
> >  newlib/libm/machine/x86_64/fesetenv.c        | 8 +++++++-
> >  newlib/libm/machine/x86_64/fesetexceptflag.c | 8 +++++++-
> >  newlib/libm/machine/x86_64/fesetround.c      | 8 +++++++-
> >  newlib/libm/machine/x86_64/fetestexcept.c    | 8 +++++++-
> >  newlib/libm/machine/x86_64/feupdateenv.c     | 8 +++++++-
> >  23 files changed, 161 insertions(+), 23 deletions(-)
> >  mode change 120000 => 100644 newlib/libm/machine/i386/feclearexcept.c
> >  mode change 120000 => 100644 newlib/libm/machine/i386/fegetenv.c
> >  mode change 120000 => 100644 newlib/libm/machine/i386/fegetexceptflag.c
> >  mode change 120000 => 100644 newlib/libm/machine/i386/fegetround.c
> >  mode change 120000 => 100644 newlib/libm/machine/i386/feholdexcept.c
> >  mode change 120000 => 100644 newlib/libm/machine/i386/fenv.c
> >  mode change 120000 => 100644 newlib/libm/machine/i386/feraiseexcept.c
> >  mode change 120000 => 100644 newlib/libm/machine/i386/fesetenv.c
> >  mode change 120000 => 100644 newlib/libm/machine/i386/fesetexceptflag.c
> >  mode change 120000 => 100644 newlib/libm/machine/i386/fesetround.c
> >  mode change 120000 => 100644 newlib/libm/machine/i386/fetestexcept.c
> >  mode change 120000 => 100644 newlib/libm/machine/i386/feupdateenv.c
> >  mode change 120000 => 100644 newlib/libm/machine/x86_64/feclearexcept.c
> >  mode change 120000 => 100644 newlib/libm/machine/x86_64/fegetenv.c
> >  mode change 120000 => 100644
> newlib/libm/machine/x86_64/fegetexceptflag.c
> >  mode change 120000 => 100644 newlib/libm/machine/x86_64/fegetround.c
> >  mode change 120000 => 100644 newlib/libm/machine/x86_64/feholdexcept.c
> >  mode change 120000 => 100644 newlib/libm/machine/x86_64/feraiseexcept.c
> >  mode change 120000 => 100644 newlib/libm/machine/x86_64/fesetenv.c
> >  mode change 120000 => 100644
> newlib/libm/machine/x86_64/fesetexceptflag.c
> >  mode change 120000 => 100644 newlib/libm/machine/x86_64/fesetround.c
> >  mode change 120000 => 100644 newlib/libm/machine/x86_64/fetestexcept.c
> >  mode change 120000 => 100644 newlib/libm/machine/x86_64/feupdateenv.c
>
> Pushed.
>
>
> Thanks,
> Corinna
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat
>