Re: [PATCH 1/2] arm: Fix fenv support
Sebastian Huber <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On 19/07/2020 13:01, Sebastian Huber wrote: > From: Eshan dhawan<[email protected]> > > The previous fenv support for ARM used the soft-float implementation of > FreeBSD. Newlib uses the one from libgcc by default. They are not > compatible. Having an GCC incompatible soft-float fenv support in > Newlib makes no sense. A long-term solution could be to provide a > libgcc compatible soft-float support. This likely requires changes in > the GCC configuration. For now, provide a stub implementation for > soft-float multilibs similar to RISC-V. > > Move implementation to one file and delete now unused files. Hide > implementation details. Remove function parameter names from header > file to avoid name conflicts. > > Provide VFP support if __SOFTFP__ is not defined like glibc. > > Reviewed-by: Sebastian Huber<[email protected]> > Signed-off-by: Eshan dhawan<[email protected]> This patch is still an improvement and fixes the ARM support of Newlib. It would be nice to commit it and then in a second step split it up into individual files.