Re: [PATCH 0/2] Fix fenv support for ARM

On 29/07/2020 07:07, Sebastian Huber wrote:

> On 27/07/2020 10:07, Corinna Vinschen via Newlib wrote:
>
>> On Jul 23 07:13, Sebastian Huber wrote:
>>> On 19/07/2020 13:01, Sebastian Huber wrote:
>>>
>>>> This patch set addresses some issues which popped up while building 
>>>> Newlib for
>>>> ARM with GCC 10 which enables -fno-common by default.
>>>>
>>>> Eshan dhawan (1):
>>>>     arm: Fix fenv support
>>>>
>>>> Sebastian Huber (1):
>>>>     arm: Remove superfluous fenv stub files
>>> I just noticed that the stub files I removed are not superfluous. 
>>> Its seems
>>> they are necessary to somehow overwrite the default implementations in:
>>>
>>> newlib/libm/fenv
>>>
>>> There seems to be some build system magic involved here. I guess we 
>>> have to
>>> split up fenv.c and move all the functions to individual files 
>>> matching the
>>> ones in newlib/libm/fenv?
>> Splitting is probably better.  When you created and tested a new 
>> patchset,
>> feel free to push it.
>
> I checked in two patches:
>
> https://sourceware.org/git?p=newlib-cygwin.git;a=commit;h=b7a6e02dc6a5289bfa489c0e7b6539abd281e2c6 
>
>
> https://sourceware.org/git?p=newlib-cygwin.git;a=commit;h=3ca43259686187e081d317e2b406724a849c9d7b 
>
>
> I hope the ARM fenv support issues are now fixed.

No, it was not fixed. I checked in an additional patch:

https://sourceware.org/git?p=newlib-cygwin.git;a=commit;h=ba283d8777b617696342cad1f973e22b03bc7c74

Now at least all the linker issues are resolved.