Re: [PATCH] doc: Various fixes to makedocbook for python3.8

On Aug 25 20:45, Jon Turney wrote:
> On 24/08/2020 11:01, Corinna Vinschen via Newlib wrote:
> > On Aug 23 20:41, Jon Turney wrote:
> > > On 23/08/2020 16:23, Ken Brown wrote:
> > > > On 8/22/2020 2:45 PM, Jon Turney wrote:
> > > > > ---
> > > > >    newlib/doc/makedocbook.py | 8 +++++---
> > > > >    1 file changed, 5 insertions(+), 3 deletions(-)
> > > > > 
> > > > > diff --git a/newlib/doc/makedocbook.py b/newlib/doc/makedocbook.py
> > > > > index 92d0f279d..3fab26f1a 100755
> > > > > --- a/newlib/doc/makedocbook.py
> > > > > +++ b/newlib/doc/makedocbook.py
> > > [...]
> > > > Would it make sense to also change the shebang line so that
> > > > makedocbook.py uses python3?  Currently the build of Cygwin on Fedora
> > > > uses python3, but the build of Cygwin on Cygwin uses python2.  This is
> > > > of no great importance, but a recent IRC discussion shows that it can be
> > > > confusing.
> > > 
> > > Yeah, I guess that would make some sense, given that python2 is now EOL.
> > > 
> > > Otoh, making it gratuitously not work with python2 seems a bit harsh.
> > > 
> > > On the gripping hand, reading PEP 0394, I see it doesn't actually require
> > > that 'python' exist at all, so I guess changing the shebang as you suggest
> > > is the right thing to do.
> > 
> > With this change, please push.
> 
> Testing on system where '/usr/bi/python' doesn't exist, there's also another
> script which I neglected to update.
> 
> Patch attached.

Go for it.


Thanks,
Corinna