Re: [PATCH 2/3] libm: Remove __ieee754_gamma_r variants

Keith Packard via Newlib <[email protected]> Thu, 03 Sep 2020 14:25:32 -0700

Newsgroups	gmane.comp.lib.newlib
Message-ID	<[email protected]>

Brian Inglis <[email protected]> writes:

>>> Then tell us what you want gamma and gamma_r to do for Cygwin.
>> 
>> I did: https://sourceware.org/pipermail/newlib/2020/017946.html

Oops! I appear to have missed that mail.

> FYI docs/spec:
> https://sca.uwaterloo.ca/coldfire/gcc-doc/docs/libm_21.html#SEC21
> http://www.ece.ualberta.ca/~cmpe401/docs/coldfire/libm.pdf#page=20
> https://ftp.rtems.org/pub/rtems/docs/3.2.0/libm-3.2.0.ps - see p.18

That's quite helpful actually and says that cygwin's gamma matches
glibc, which makes the change from 2002 just a bug. Switching gamma back
to lgamma is quite simple.

Here's what I did:

 1. Remove the gamma* function implementations and make them explicit
    aliases to lgamma*.

 2. Change the name of the __ieee754_gamma* functions to
    __ieee754_tgamma* and remove the _ieee754_gamma*_r variants

I've sent a patch doing this to the list.

-- 
-keith

signature.asc (application/pgp-signature, 832 B)