Re: [PATCH 1/3] libc/include/inttypes.h: Remove parameter name

Patch applied.  Thanks.

-- Jeff J.

On Fri, Oct 2, 2020 at 2:52 AM Torbjorn SVENSSON <[email protected]>
wrote:

> Patch attached.
>
>
>
> *From:* Jeff Johnston <[email protected]>
> *Sent:* den 2 oktober 2020 01:23
> *To:* Torbjorn SVENSSON <[email protected]>
> *Cc:* Newlib <[email protected]>
> *Subject:* Re: [PATCH 1/3] libc/include/inttypes.h: Remove parameter name
>
>
>
> Looks fine.  Could you please resend the patch as an attachment?
>
>
>
> Thanks,
>
>
>
> -- Jeff J.
>
>
>
> On Thu, Oct 1, 2020 at 10:19 AM Torbjörn SVENSSON via Newlib <
> [email protected]> wrote:
>
> As discussed in GCC bug 97088
> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
> prototypes of library functions should use reserved names, or no name
> at all.
>
> This patch removes the 'j' parameter name from
> extern intmax_t  imaxabs(intmax_t);
>
> to avoid possible clashes with user code in case someone uses
> before including Newlib's inttypes.h (or uses some other conflicting
> definition)
>
> Signed-off-by: Torbjörn SVENSSON <[email protected]>
> ---
>  newlib/libc/include/inttypes.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/newlib/libc/include/inttypes.h
> b/newlib/libc/include/inttypes.h
> index 073215476..570ed0481 100644
> --- a/newlib/libc/include/inttypes.h
> +++ b/newlib/libc/include/inttypes.h
> @@ -320,7 +320,7 @@ struct _reent;
>  extern "C" {
>  #endif
>
> -extern intmax_t  imaxabs(intmax_t j);
> +extern intmax_t  imaxabs(intmax_t);
>  extern imaxdiv_t imaxdiv(intmax_t numer, intmax_t denomer);
>  extern intmax_t  strtoimax(const char *__restrict, char **__restrict,
> int);
>  extern intmax_t  _strtoimax_r(struct _reent *, const char *__restrict,
> char **__restrict, int);
> --
> 2.18.0
>
>