Re: [PATCH v2] libc/time: Move internal newlib tz-structs to local.h

I also like this solution, but again as I mentioned earlier, it technically
requires a major release bump due to the removal of API from time.h and
would be best
to wait until we have something else warranting a major release bump.

That said, what do you think Corinna?

-- Jeff J.

On Thu, Oct 15, 2020 at 12:47 PM Torbjorn SVENSSON via Newlib <
[email protected]> wrote:

> Hello Corinna,
>
> Thanks for the feedback and I hope that you had a nice vacation!
>
> I haven't run tests with your patch applied, but just reading it should be
> fine.
> I see no reason why "sys/_tz_structs.h" would be included from
> "bits/stdc++.h", and it is this particular include chain that is causing
> the problems in the libstdc ++ test suite, so if it works for Cygwin, I'd
> say go for it!
>
> Kind regards,
> Torbjörn
>
> -----Original Message-----
> From: Corinna Vinschen <[email protected]>
> Sent: den 15 oktober 2020 12:22
> To: Torbjorn SVENSSON <[email protected]>
> Cc: [email protected]
> Subject: Re: [PATCH v2] libc/time: Move internal newlib tz-structs to
> local.h
>
> On Oct 15 06:52, Torbjorn SVENSSON via Newlib wrote:
> > Ping!
>
> Due to vacation I only just checked now.  The patch breaks the Cygwin
> build.  Especially __tzinfo_type has to be exposed from a public header
> in newlib.
>
> So what about the attached patch instead?
>
>
> Corinna
>