Re: [PATCH] arm: Fix memchr() for Armv8-R
Jeff Johnston via Newlib <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <CAOox84vJRG0C5Du87HY14fr-kVOv9-tgWqesW0mJeOHjNpwVHg@mail.gmail.com> |
Patch applied to master as there were was no objection from Richard, even though he suggests the function needs resyncing. If someone wants to do the resync before end-of-year, please get approval from Richard or Arm team. -- Jeff J. On Fri, Dec 4, 2020 at 2:42 AM Sebastian Huber < [email protected]> wrote: > The Cortex-R52 processor is an Armv8-R processor with a NEON unit. This > fix prevents conflicting architecture profiles A/R errors issued by the > linker. > > Signed-off-by: Sebastian Huber <[email protected]> > --- > newlib/libc/machine/arm/memchr.S | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/newlib/libc/machine/arm/memchr.S > b/newlib/libc/machine/arm/memchr.S > index 7c22b117e..1a4c6512c 100644 > --- a/newlib/libc/machine/arm/memchr.S > +++ b/newlib/libc/machine/arm/memchr.S > @@ -79,7 +79,11 @@ > > @ NOTE: This ifdef MUST match the one in memchr-stub.c > #if defined (__ARM_NEON__) || defined (__ARM_NEON) > +#if __ARM_ARCH >= 8 && __ARM_ARCH_PROFILE == 'R' > + .arch armv8-r > +#else > .arch armv7-a > +#endif > .fpu neon > > > -- > 2.26.2 > >