Re: [PATCH 1/1] libc: Added implementation for sig2str/str2sig.

Corinna Vinschen <[email protected]>
Newsgroups gmane.comp.lib.newlib
Message-ID <[email protected]>
Hi Matt,

this looks good.  I pushed it with two minor changes in terms of
the documentation:

On Jul 31 15:22, Matt Joyce wrote:
> +FUNCTION
> +<<sig2str>>---translate between signal number and name
> +<<str2sig>>---translate between signal name and number

This doesn't work as desired.  I changed it to

  <<sig2str>>, <<str2sig>>---Translate between signal number and name

> +
> +INDEX
> +          sig2str
> +INDEX
> +          str2sig
> +
> +SYNOPSIS
> +          #include <signal.h>
> +          int sig2str(int <[signum]>, char *<[str]>);
> +
> +          int str2sig(const char *restrict <[str]>, int *restrict <[pnum]>);
> +
> +DESCRIPTION
> +The <<sig2str>> function translates the signal number specified by <[signum]> to
> +a signal name and stores this string in the location specified by <[str}>. The
                                                                     ^^^^^^^
opening square bracket vs. closing curly brace?  Uh oh ;)

Apart from that I created a new Makefile.in from your Makefile.am
change and added the str2sig entry to the documentation file
newlib/libc/signal/signal.tex.

I'll add the new functions as Cygwin exports later today.

Thanks for your patch and your patience while trying to get it right!


Corinna
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.