Re: [PATCH 1/1] libc: Added prototypes for new POSIX APIs

On Fri, Aug 6, 2021 at 12:48 PM Corinna Vinschen <[email protected]> wrote:
>
> Hi Matt,
>
> On Aug  6 16:07, Matt Joyce wrote:
> > Added function prototypes to newlib/libc/include/pthread.h
> > for the following Issue 8 Standard APIs:
> > pthread_cond_clockwait()
> > pthread_mutex_clocklock()
> > pthread_rwlock_clockrdlock()
> > pthread_rwlock_clockwrlock()
> > ---
> >  newlib/libc/include/pthread.h | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git a/newlib/libc/include/pthread.h b/newlib/libc/include/pthread.h
> > index c9d24d6e0..9b91ea68d 100644
> > --- a/newlib/libc/include/pthread.h
> > +++ b/newlib/libc/include/pthread.h
> > @@ -87,6 +87,13 @@ int        pthread_mutex_timedlock (pthread_mutex_t *__mutex,
> >
> >  #endif /* _POSIX_TIMEOUTS */
> >
> > +/* Using __MISC_VISIBLE until POSIX Issue 8 is officially released */
> > +#if __MISC_VISIBLE
>
> I think these symbols should use the __GNU_VISIBLE feature test macro.
> That would also be compatible with GLibC.

Thanks Corinna. I'll take the bullet for telling him to use that one.

--joel

>
>
> Corinna
>