Re: [PATCH] newlib: mips: delete glibc-specific logic
Corinna Vinschen <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On Nov 8 22:21, Mike Frysinger wrote: > This code looks like it's written to be copied & pasted between diff > C libraries and relies on _LIBC only being used with glibc. This will > break when newlib changes from _COMPILING_NEWLIB to _LIBC, so delete > the glibc-specific logic ahead of time. > --- > newlib/libc/machine/mips/memcpy.S | 11 ----------- > newlib/libc/machine/mips/memset.S | 10 ---------- > newlib/libc/machine/mips/strcmp.S | 9 --------- > 3 files changed, 30 deletions(-) ACK, please push. There's a Cygwin patch required as well (winsup/cygwin/tzcode/private.h) before we can change to _LIBC. Do you want to do that or shall I? Thanks, Corinna