Re: [PATCH] update to Unicode 14.0
Thomas Wolff <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
Am 15.11.2021 um 14:06 schrieb Corinna Vinschen: > On Nov 11 21:32, Thomas Wolff wrote: >> Unicode update patch attached. >> Responses to previous comments: >>> wouldn't it make sense to remove the temporary downloaded files like >>> libc/ctype/UnicodeData.txt, etc? >>> Either automatically after creating the generated files >> Maybe. I didn't implement it, like in my other projects (mintty, mined), as >> it causes redundant multiple downloads during development. >>> or in a matching MAINTAINERCLEANFILES variable in Makefile.am? >> I had looked into it but there isn't such a variable yet and I'm not >> familiar with automake/conv stuff, so feel free to add if suitable. >>> Also, maybe it makes sense to add these temporary files to the .gitignore file? >> I'm not in favour of the .gitignore idea as its only purpose seems to be to >> smooth out effects of `git add *`-like check-ins, which I think shouldn't be >> done anyway; I feel the concept encourages sloppy repository management. >> But again, this isn't my project so feel free to adjust the build. > It's not my project either, it's a collaborative effort. So you don't have any other idea to fix this issue? To be honest, I don't really understand the issue. So the files stay hanging around for someone who builds the update. What's the problem? I'm willing to fix whatever doesn't fit. Thomas