Re: [PATCH 2/2] ctype: use less short names in public header
Jonathan Wakely <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On 09/11/21 19:18 -0500, Mike Frysinger wrote: >On 09 Nov 2021 12:38, Corinna Vinschen wrote: >> On Nov 8 20:24, Mike Frysinger wrote: >> > We're seeing a build failure in GNU sim code which is using _P locally >> > but the ctype.h define clashes with it. Rename these to use the same >> > symbols that glibc does. They're a bit more verbose, but seems likely >> > that we'll have fewer conflicts if glibc isn't seeing them. >> ^^^^^ >> Mixing newlib and glibc? That's just a typo, I guess? > >i meant glibc here. these are the same symbol names that glibc is using, >and it's not seeing conflicts in the wider ecosystem. so if they aren't >seeing issues, it's likely newlib won't either if it uses the same names. There's a reason you don't see conflicts with those names: They are reserved names, just like _P. Any user code that conflicts with those names has a bug and needs fixing.