Re: Error in posix_spawn(3) man page

On Fri, Jan 7, 2022 at 1:32 AM Corinna Vinschen <[email protected]> wrote:
>
> Hi Keith,
>
> On Jan  5 13:39, Keith Thompson wrote:
> > On Wed, Jan 5, 2022 at 3:47 AM Corinna Vinschen <[email protected]> wrote:
> > >
> > > Hi Keith,
> > >
> > > On Dec 28 19:24, Keith Thompson wrote:
> > > > The posix_spawn(3) man page has incorrect types for the argv and
> > > > envp parameters for the posix_spawn and posix_spawnp functions.
> > > >
> > > > They're shown as
> > > >     char *const argv, char *const envp
> > > > when they should be
> > > >     char *const argv[], char *const envp[]
> > > >
> > > > Suggested patch (though I'm not 100% sure how the square brackets
> > > > are handled when generating the man page):
> > >
> > > Please send a git compatible patch in `git format-patch' format.
> > >
> > >
> > > Thanks,
> > > Corinna
> >
> > As requested. Given the way I copy-and-pasted the patch into my email,
> > it might not have
> > treated tabs correctly.
>
> It's not TABs, it's an incorrect patch format:
>
> $ git am 0001-Fix-documented-argv-and-envp-params-for-posix_spawn.patch
> Applying: Fix documented argv and envp params for posix_spawn
> error: libc/posix/posix_spawn.c: does not exist in index
> Patch failed at 0001 Fix documented argv and envp params for posix_spawn
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> [...]
>
> Did you actually create the patch with `git format-patch'?
>
>
> Thanks,
> Corinna

The problem was that I had diff.noprefix=true in my $HOME/.gitconfig.
It caused `git format-patch` to omit the `a/` and `b/` prefixes, and `git am`
doesn't appear to have any way to consume a patch with those prefixes missing.

I've attached an updated patch that should apply cleanly.

(I'd argue that this is a git bug, but of course this isn't the place
to report it.)

From 7fdfe8c2549b53ea36d68b879020e0236d6480ac Mon Sep 17 00:00:00 2001
From: Keith Thompson <[email protected]>
Date: Wed, 5 Jan 2022 13:30:16 -0800
Subject: [PATCH] Fix documented argv and envp params for posix_spawn

---
 newlib/libc/posix/posix_spawn.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/newlib/libc/posix/posix_spawn.c b/newlib/libc/posix/posix_spawn.c
index 005471fde..85bfa6477 100644
--- a/newlib/libc/posix/posix_spawn.c
+++ b/newlib/libc/posix/posix_spawn.c
@@ -39,11 +39,11 @@ SYNOPSIS
 	int posix_spawn(pid_t *<[pid]>, const char *<[path]>,
 			const posix_spawn_file_actions_t *<[file_actions]>,
 			const posix_spawnattr_t *<[attrp]>,
-			char *const <[argv]>, char *const <[envp]>);
+			char *const <[argv]>[], char *const <[envp]>[]);
 	int posix_spawnp(pid_t *<[pid]>, const char *<[file]>,
 			const posix_spawn_file_actions_t *<[file_actions]>,
 			const posix_spawnattr_t *<[attrp]>,
-			char *const <[argv]>, char *const <[envp]>);
+			char *const <[argv]>[], char *const <[envp]>[]);
 
 DESCRIPTION
 Use <<posix_spawn>> and <<posix_spawnp>> to create a new child process
-- 
2.33.1