Re: [PATCH 0/8] newlib: convert newlib.h to autoheader

Corinna Vinschen <[email protected]>
Newsgroups gmane.comp.lib.newlib
Message-ID <[email protected]>
On Jan 17 23:47, Mike Frysinger wrote:
> This is a series of cleanups to make newlib.hin be managed automatically
> by autoheader instead of being hand maintained.  This will also make the
> standard autoreconf command not fall over due to the current poor state
> of the header files, as well as not make it corrupt/clobber the version
> header file.
> 
> I've split these up to (hopefully) make it easier to review, and be easy
> to merge most of them independently.  If there is some reason we don't
> want to actually leverage autoheader, or maybe we want to rework how the
> final step is done, we can still land the rest of the stack while that
> discussion is ongoing.
> 
> Mike Frysinger (8):
>   newlib: internalize HAVE_INITFINI_ARRAY
>   newlib: merge acconfig.h changes into newlib.hin
>   newlib: clean up autoheader templates
>   newlib: sort newlib.h output
>   newlib: move version defines out of the config headers
>   newlib: add missing _NANO_MALLOC to newlib.hin
>   newlib: iconv: autogenerate iconv define list
>   newlib: switch newlib.h to autoheader
> 
>  newlib/Makefile.in                 |  34 +-
>  newlib/_newlib_version.hin         |  16 +-
>  newlib/acconfig.h                  | 191 --------
>  newlib/aclocal.m4                  |   1 +
>  newlib/configure                   | 695 ++++++++++++++++++++++++-----
>  newlib/configure.ac                | 105 +++--
>  newlib/configure.host              |   2 +-
>  newlib/iconv.m4                    | 305 +++++++++++++
>  newlib/libc/iconv/ces/mkdeps.pl    |  39 ++
>  newlib/libc/misc/fini.c            |   6 +-
>  newlib/libc/misc/init.c            |   6 +-
>  newlib/libc/stdlib/__call_atexit.c |   2 +-
>  newlib/libc/sys/arm/crt0.S         |   2 +-
>  newlib/newlib.hin                  | 503 +++++++++++++++------
>  14 files changed, 1398 insertions(+), 509 deletions(-)
>  delete mode 100644 newlib/acconfig.h
>  create mode 100644 newlib/iconv.m4
> 
> -- 
> 2.33.0

The patchset looks good to me.  Please push.


Thanks,
Corinna
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.