Re: [PATCH] newlib: merge iconvdata into top-level Makefile
Corinna Vinschen <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On Jan 22 01:04, Mike Frysinger wrote: > Avoid a recursive make with this tiny subdir to speed things up a bit. > --- > NB: I can't easily test this because it's only built for i686-pc-linux, > and I only have GNU C library toolchains using that tuple. My half > attempts at building it *look* like it uses the right flags. > > newlib/Makefile.am | 7 +- > newlib/Makefile.in | 186 +- > newlib/configure | 22 +- > newlib/configure.ac | 6 +- > newlib/iconvdata/Makefile.am | 23 - > newlib/iconvdata/Makefile.in | 643 -- > newlib/iconvdata/aclocal.m4 | 1178 --- > newlib/iconvdata/configure | 14169 -------------------------------- > newlib/iconvdata/configure.ac | 22 - > newlib/iconvdata/local.mk | 20 + > 10 files changed, 201 insertions(+), 16075 deletions(-) > delete mode 100644 newlib/iconvdata/Makefile.am > delete mode 100644 newlib/iconvdata/Makefile.in > delete mode 100644 newlib/iconvdata/aclocal.m4 > delete mode 100755 newlib/iconvdata/configure > delete mode 100644 newlib/iconvdata/configure.ac > create mode 100644 newlib/iconvdata/local.mk Looks good, except, there's this local.mk again. I don't think this name is overly helpful. All Makefiles, even those just included by the master Makefile should be called Makefile.somethingorother, IMHO. These are much easier to find for people new to the stuff. Same goes for the already existing newlib/doc/local.mk which I missed when reviewing the patches... Thanks, Corinna