Re: [PATCH 1/3] libgloss: merge epiphany & libnosys & or1k configure scripts up a level

On Jan 26 21:32, Mike Frysinger wrote:
> On 26 Jan 2022 13:30, Corinna Vinschen wrote:
> > On Jan 26 04:45, Mike Frysinger wrote:
> > > These subdirs have unique configure scripts to do some compiler tests.
> > > The checks should work for all targets, so hoist them up to the top
> > > libgloss dir.  This should allow us to delete these subdir configure
> > > scripts.
> > 
> > For some reason this patch doesn't apply cleanly to current git master:
> > 
> >   Applying: libgloss: merge epiphany & libnosys & or1k configure scripts up a level
> >   error: git apply: bad git-diff - inconsistent old filename on line 38
> >   Patch failed at 0001 libgloss: merge epiphany & libnosys & or1k configure scripts up a level
> >   [...]
> 
> probably because the deletions were removed from the patch before posting
> to avoid going over the mailing list limit and make it easier to focus on
> the actual changes, not generated content.
> 
> binutils/gdb allows devs to push to refs/heads/users/$USER/xxx.  glibc
> allows refs/heads/$USER/xxx.  should we carve out similar space here ?
> then i could push my branches there and it'd be easy for you to git
> fetch && git merge with the right state.  no need to sync multiple
> e-mails to your local tree.
> 
> > I'm a bit concerned that this patchset removes setting and AC_SUBST'ing
> > host_makefile_frag_path while the variable is still used by various
> > Makefile.in files...
> 
> sorry, but what are you looking at ?  it isn't deleting that setting.
> the top level configure script has always had (and i'm not removing):
> host_makefile_frag=${srcdir}/config/default.mh
> host_makefile_frag_path=$host_makefile_frag
> AC_SUBST(host_makefile_frag_path)
> AC_SUBST_FILE(host_makefile_frag)
> 
> so when i delete libgloss/$ARCH/configure, they don't lose that setting,
> they simply get it from the top level configure instead of the $ARCH one.
> -mike

Ok, please push.


Thanks,
Corinna