Re: [PATCH 1/5 v2] newlib: libm: move manual into top-level build

On 31 Jan 2022 14:58, Jon Turney wrote:
> On 28/01/2022 07:58, Mike Frysinger wrote:
> > --- /dev/null
> > +++ b/newlib/libm/Makefile.inc
> > @@ -0,0 +1,26 @@
> > +info_TEXINFOS += %D%/libm.texi
> > +%C%_libm_TEXINFOS = %D%/targetdep.tex $(LIBM_CHEWOUT_FILES)
> > +
> > +LIBM_CHEWOUT_FILES =
> > +
> > +LIBM_CHAPTERS =
> > +
> > +%D%/libm.dvi: %D%/targetdep.tex $(LIBM_CHEWOUT_FILES)
> > +
> > +%D%/targetdep.tex: $(LIBM_CHAPTERS)
> > +	$(AM_V_GEN)cat $^ > [email protected]
> > +	$(AM_V_at)$(SHELL) $(newlib_basedir)/../move-if-change [email protected] $@
> > +	$(AM_V_at)touch $@
> 
> We carefully only update $@ if it's changed, then touch it anyhow?
> 
> This seems like a transcription error, since originally we were touching 
> a timestamp file, or perhaps leftover from testing?

you're right of course.  i saw other places that weren't using the stamp
idiom, and then when rewriting these rules i remembered those places and
thought i wouldn't bother deploying the stamp pattern here since it was
already doing it wrong.  but i misremembered which ones were wrong.

> The same pattern occurs later, as well.

which one do you mean ?  the .xml ones ?  those currently aren't using the
stamp idiom.  or do you just mean the multiple places where targetdep.tex
is generated ?

> > --- a/newlib/libm/common/Makefile.am
> > +++ b/newlib/libm/common/Makefile.am
> >   
> > -CHAPTERS =
> > +LIBM_CHEWOUT_FILES =
> > +LIBM_CHAPTERS =
> > +include ./Makefile.inc
> 
> Is this boilerplate really needed before including the makefile 
> fragment, since '+=' should work even if the variable isn't already defined?

yes, automake enforces it

ideally we'll kill all libm/*/Makefile.am files at which point this boiler
plate isn't needed since there will just be the one set in the top-level
libm/Makefile.am.  i'm holding off on doing that clean up until i can finish
landing my current batch of changes.
-mike

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmH4q5YACgkQQWM7n+g3
9YEEvw//Xwul4oAcuftAm0fYCfMv7D43nD9co0mPX6y155Ou8CxYrnKhQ/5WqcLc
513+3eTUwPx4oyAHjKkDNgvskQJLXR6kjGLvAQfdJ5+iPTvJFcaaia+DUDqjDy2t
ANAmHb8wVrzpKKcT7SVp1UkDlh1LZ6xjCkQjmMm6S2ObSMRYSlvSEYfqFC+Fgd/B
6ygwMZ7xOpo3T6AUTLp8z872+SVT/1pTzesBaEgP6UEQ4PktUEsyzp+lwmAI4G1v
NqBXDPvJwFEvjaKYS/x5CvDJf0ddBHmDxx0+6xvgdS6l3QukJSCDdVnanKI/J1Jn
2McU+eD6spSdZKhuPLfqn7PbeI9uS+mMFjGE+jAlnqhhwem1X0lKBzkzMZ2CuLi8
WMCTr6Gdrmxpy4Wys32eIytBB7YfLDJbsl0jmdigwlSd5IuX/HZZyWv6Wy64ZicJ
L6Dbu6kVoinOR3lJVAQCNcRpyGr1HwBuOp3pcKSsFgEt6yZRmpJpJtmmsE9CKoSV
o5aKxK8NLa/210OdHOvqZDAYiZCT7l/+9FnpRlK8FvzqA4q9y6kDLyqSbSI57JSi
vZ37zO9dNoSgwb/75Ye1b2BxSYVAabAGqxWgFVSWsc5VNHjRlw+kLUKy4Dh+NdB8
aFxUeI3+7BJoopYLHsEu5OfoEwvrygK6tOlhtfVPj841aerqKx4=
=kL2B
-----END PGP SIGNATURE-----