Re: [PATCH 3/6] newlib: drop unused iconvdata

Funny thing that we had been discussing this amongst some of the RTEMS
developers. It was improperly licensed for newlib unless only used for
Linux. And the placement in the tree didn't .ake that clear.

Good riddance since you determined it wasn't needed.

Thanks for this bit.

--joel

On Mon, Feb 7, 2022, 7:58 PM Mike Frysinger <[email protected]> wrote:

> This was only ever used for i?86-pc-linux-gnu targets, but that's been
> broken for years, and has since been dropped.  So clean this up too.
> ---
>  newlib/Makefile.am                   |    3 -
>  newlib/Makefile.in                   |  157 +-
>  newlib/configure                     |   20 +-
>  newlib/configure.ac                  |    3 -
>  newlib/iconvdata/EUC-JP.irreversible |    2 -
>  newlib/iconvdata/Makefile.inc        |   20 -
>  newlib/iconvdata/SJIS.irreversible   |    5 -
>  newlib/iconvdata/dummy.c             |    1 -
>  newlib/iconvdata/euc-jp.c            |  246 --
>  newlib/iconvdata/gconv-modules       | 1511 --------
>  newlib/iconvdata/jis0201.c           |   58 -
>  newlib/iconvdata/jis0201.h           |   60 -
>  newlib/iconvdata/jis0208.c           | 5012 --------------------------
>  newlib/iconvdata/jis0208.h           |  106 -
>  newlib/iconvdata/jis0212.c           | 3940 --------------------
>  newlib/iconvdata/jis0212.h           |  110 -
>  newlib/iconvdata/sjis.c              | 4512 -----------------------
>  17 files changed, 36 insertions(+), 15730 deletions(-)
>  delete mode 100644 newlib/iconvdata/EUC-JP.irreversible
>  delete mode 100644 newlib/iconvdata/Makefile.inc
>  delete mode 100644 newlib/iconvdata/SJIS.irreversible
>  delete mode 100644 newlib/iconvdata/dummy.c
>  delete mode 100644 newlib/iconvdata/euc-jp.c
>  delete mode 100644 newlib/iconvdata/gconv-modules
>  delete mode 100644 newlib/iconvdata/jis0201.c
>  delete mode 100644 newlib/iconvdata/jis0201.h
>  delete mode 100644 newlib/iconvdata/jis0208.c
>  delete mode 100644 newlib/iconvdata/jis0208.h
>  delete mode 100644 newlib/iconvdata/jis0212.c
>  delete mode 100644 newlib/iconvdata/jis0212.h
>  delete mode 100644 newlib/iconvdata/sjis.c
>
> diff --git a/newlib/Makefile.am b/newlib/Makefile.am
> index 1e35e64300fa..c6a2b3fe9dca 100644
> --- a/newlib/Makefile.am
> +++ b/newlib/Makefile.am
> @@ -505,9 +505,6 @@ TEXINFO_TEX = ../texinfo/texinfo.tex
>  if HAVE_DOC
>  include doc/local.mk
>  endif
> -if HAVE_ICONVDATA
> -include iconvdata/Makefile.inc
> -endif
>  include libc/Makefile.inc
>  include libm/Makefile.inc
>
> diff --git a/newlib/configure.ac b/newlib/configure.ac
> index 366fffafcff3..0ae3e4bb28a5 100644
> --- a/newlib/configure.ac
> +++ b/newlib/configure.ac
> @@ -347,9 +347,6 @@ AM_CONDITIONAL(HAVE_DOC, test x$have_multisubdir = xno)
>  # subdirectory withing the build directory.
>  AM_CONDITIONAL(HAVE_MULTISUBDIR, test x$have_multisubdir = xyes)
>
> -HAVE_ICONVDATA=false
> -AM_CONDITIONAL([HAVE_ICONVDATA], $HAVE_ICONVDATA)
> -
>  CRT0=
>  CRT0_DIR=
>  if test "x${have_crt0}" = "xyes"; then
> --
> 2.34.1
>
>