Re: [PATCH v2 1/1] Make __sdidinit unused

Hi Matt,

On Feb 18 10:45, Matthew Joyce wrote:
> Remove dependency on __sdidinit member of struct _reent to check
> object initialization. Like __sdidinit, the __cleanup member of
> struct _reent is initialized in the __sinit() function. Checking
> initialization against __cleanup serves the same purpose and will
> reduce overhead in the __sfp() function in a follow up patch.

The patch looks right now.  But.

What exactly are you going to do in __sfp?  The reason I'm asking is
that it's absolutely not clear yet which purpose this change serves.
Looking at this patch, I only see that, rather than using an available
flag, a pointer is now set to an invalid value -1, which looks more
dangerous than what we did before.

Care to explain or, even better, send the patch you have in mind?


Thx,
Corinna