Re: [PATCH 3/6] newlib: xstormy16: fix mallopt definition & mstats handling

On Mar  1 20:36, Mike Frysinger wrote:
> The mallopt symbol is defined in tiny-malloc.c, not mallocr.c, but
> the Makefile in here tries to compile it out of the latter.  This
> leads to mallopt never being defined.
> 
> The build also creates mallinfo.o & mallopt.o & mallstats.o objects
> to override common ones, but the common dir doesn't use these names.
> Instead, it places these all in mstats.o.
> 
> So move the build define logic to a dedicated file and compile it
> directly to make things a bit simpler while fixing the missing func
> and aligning objects with the cmomon code.
> ---
>  newlib/libc/machine/xstormy16/Makefile.am | 15 ++--------
>  newlib/libc/machine/xstormy16/Makefile.in | 36 +++++++++++++----------
>  newlib/libc/machine/xstormy16/mstats.c    |  6 ++++
>  3 files changed, 29 insertions(+), 28 deletions(-)
>  create mode 100644 newlib/libc/machine/xstormy16/mstats.c
> [...]
> diff --git a/newlib/libc/machine/xstormy16/mstats.c b/newlib/libc/machine/xstormy16/mstats.c
> new file mode 100644
> index 000000000000..1bd24da555f1
> --- /dev/null
> +++ b/newlib/libc/machine/xstormy16/mstats.c
> @@ -0,0 +1,6 @@
> +/* stdlib/mstats.c defines all these symbols in this file.
> +   TODO: Missing mstats function.  */
> +#define DEFINE_MALLINFO
> +#define DEFINE_MALLOC_STATS
> +#define DEFINE_MALLOPT
> +#include "tiny-malloc.c"

XStormy16 is such a small target, it would be better to split these into
three files.


Corinna