Re: [PATCH] newlib: fix build with <gcc-5 versions
Mike Frysinger <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <Yi90KGVctRBCAr4C@vapier> |
On 14 Mar 2022 08:36, Sebastian Huber wrote:
> On 14/03/2022 04:25, Mike Frysinger wrote:
> > __builtin_mul_overflow showed up with gcc-5, so stub it out for older
> > versions.
>
> The __builtin_mul_overflow() performs a multiplication and an overflow
> check. Just replacing this with 0 is not the same.
i'm aware it does the check. i figured since <gcc-5 isn't that common, it
isn't worth the effort doing the ad-hoc ({...}) function definition trying
to maintain the same semantics. although it should at least do the actual
multiplication & assignment.
-mike
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIvdCgACgkQQWM7n+g3 9YGDahAAjJBruIXa/rXmvFHPPDw8HsQl/J+icumtvbFJn/VPqKncr6vlAv+s+uE0 QUXF9st3mpdJFQufZ21dlrKHt32Onmh6+ueWZwDt0+4xc1lKQ78FuFBHoEoye6ze 2TOGRYFtllDdq/0n3uj6tUHZXltOnRDkru3KGFfPfD1zPs1a8zLGozTe6dIUKejm SqZ6LN0dhBul2jW1AlDmtQZq+FK+MSFGHiV6rMhnLw9rj8oWbhu8ON8Nq+QacyBh 4lO4C1JM37Kx+WjJaMSr+LI9McM1LuQi7xhSZpaTGCWu9WEX+BnD4jKj/MBdBB0H SVJRQRok3kj1DkE67WZ+Q0BL+OTJIzeFWSP1Zy0e3VkxcGo7uC7bL4f9AbV6ASs4 SKSkDxSjEbz0VaZesP3HG9ZFlrJPGKVDUg3u4jgR8WI8OzsKV9rv3FFb2USkwWrY wZByqBvlBgagr0wym9N6aadt6baMcAGzELEoX8jfUP1cP0F5IoCAaw7+EpalL1Cm ZSgyT3nV+kBMyMZTB0f+SkmdGsRiAHSaAOdEOqM09ADuzAXasFnxiTkyR+mWkY0Z /UhfGzMPT/Ej69dCAwOG3hTuPca2XMzwoXy09kaLhgeLllbNOne58l8kXae7JDdj vC5qCzp1GkyHHQSHLSdDKXLpY+mJC90shLRsGOJ7TPQfO0dSxkU= =eETy -----END PGP SIGNATURE-----