Re: [PATCH newlib] libc/include/malloc.h: Add prototype for GNU extension malloc_usable_size()

C Howland <[email protected]>
Newsgroups gmane.comp.lib.newlib
Message-ID <CANk6obQ3F2Y2WcKEbphBRr1i9q6t9UNgrMUSxwjN0TW-NFhpPg@mail.gmail.com>
>
> ------------------------------
> *From:* Newlib <[email protected]> on
> behalf of Joel Sherrill <[email protected]>
> *Sent:* Tuesday, March 15, 2022 11:16 AM
> *To:* [email protected] <[email protected]>
> *Subject:* [PATCH newlib] libc/include/malloc.h: Add prototype for GNU
> extension malloc_usable_size()
>
>
> This is not provided by the newlib malloc implementation but may
> be available in external implementations.
> ---
>  newlib/libc/include/malloc.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/newlib/libc/include/malloc.h b/newlib/libc/include/malloc.h
> index a9dc5bca6..e73095e1e 100644
> --- a/newlib/libc/include/malloc.h
> +++ b/newlib/libc/include/malloc.h
> @@ -137,6 +137,10 @@ extern void __malloc_lock(struct _reent *);
>
>  extern void __malloc_unlock(struct _reent *);
>
> +#if __GNU_VISIBLE
> +extern size_t malloc_usable_size(void *);
> +#endif
> +
>  /* A compatibility routine for an earlier version of the allocator.  */
>
>  extern void mstats (char *);
> --
> 2.24.4
>
>
     Sorry, but I fail to see why adding this makes sense.  If there's an
application which adds a function they should be editing the header file
when they add it.  (There's not even a stub being supplied here.)
Additionally, the Linux man page for the function says "The main use of
this function is for debugging and introspection."  That is, it is not even
a general application utility, but of very limited use.  Either provide the
function with the prototype or no prototype.
                                    Craig
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.