Re: [PATCH v2] newlib: fix build with <gcc-5 versions
Mike Frysinger <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <YjEnGIyU31Kl6zYJ@vapier> |
On 15 Mar 2022 12:41, Richard Earnshaw wrote:
> On 15/03/2022 03:25, Mike Frysinger wrote:
> > __builtin_mul_overflow showed up with gcc-5, so stub it out for older
> > versions.
> > ---
> > newlib/libc/include/sys/cdefs.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/newlib/libc/include/sys/cdefs.h b/newlib/libc/include/sys/cdefs.h
> > index da729092185c..e51f7f4b873a 100644
> > --- a/newlib/libc/include/sys/cdefs.h
> > +++ b/newlib/libc/include/sys/cdefs.h
> > @@ -416,6 +416,10 @@
> > #define __unreachable() ((void)0)
> > #endif
> >
> > +#if !__GNUC_PREREQ__(5, 0)
> > +#define __builtin_mul_overflow(a, b, size) ({ *(size) = (a) * (b); 0; })
>
> Wouldn't
> (*(size) = (a) * (b), 0)
>
> be more portable (avoiding the GNU statement expression extension)?
sure, that works too, thanks
-mike
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIxJxgACgkQQWM7n+g3 9YED+w//bXrsR6iniSmK6Q5tGrLmcB2hUV6bvC+rmYv0CHotbBEhWLmyPPxWC0Ga qN8PuQoVIzrWDI/j/R5QyJs23uSL4Gb3QfgHyWl0AP/gl6i7MUUjneK2qoJX3yqC SBdAAYMj8/dAOWdbys1C6bNV+JiFk+hAueUlrZRlOnXUDvbD7Ymo/HBANaiw0eem kmyO7vpp+oNFMQ5hE2qaT3lWOwE4vuP/peGoI19xRP3RGi27GA490tEU/PNXWRvH WDkNTk+GwgVh/nfGUNwIkbTd7gpNesFc4cEWo5/knyctNbZFxyE0TEkhhMl0rDXT jI1XZdyMz9rT+m155ET4omUD2Cds2PPUqcsWZUpnuG4KkrH+wFShLzIXcEDLFGZM FXBFj5UAec9Zns9zuMTf/NlfRKN2ovscpb3lEBGYiEPjVU65af1hjqbww5d7mSuy ePSSljROWss+gVAC8o+0MhIH+4pUCWCszKlSJao5Gcf5vWh4bgN5edcOMX3ViscH 4IrHiVWYnD2YI0HxH39pqmhBmt7x270H5u1NmsnQsJn4liFh5OfASylA/qQgymL7 A1yhkGdrlgQ0LPoyf3Uy/R+7E6xd+O9zf8HvRzR1pyHGlGTO+JjJID/2Zni8TNDj pg9nuol8N+ioYie2LvGOz5BA+1xVakrSgrTN5WY8D2WqB7ewSGk= =QFjS -----END PGP SIGNATURE-----