Re: [Patch] (1/n) newlib: Only call _fputwc_r if ELIX_LEVEL >= 4 (was: Build-dependency issues with ELIX_LEVEL)
Jeff Johnston <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <CAOox84uv4QB8F7iW2n+XSaGB55khAMoxo9cVgftDpnAPo9EkMg@mail.gmail.com> |
Hi Tobias. This patch was merged to master. Thanks, -- Jeff J. On Wed, Mar 30, 2022 at 5:44 AM Tobias Burnus <[email protected]> wrote: > Hello, > > this packages the the first patch of last/first email in this thread. > > As described in the commit log (and previous email), > __sprint_r and __sfputs_r of (nano-)vfprintf.c > call fputwc.c's _fputwc_r. > > While the vfprintf.c file is compiled for ELIX_LEVEL >= 1, > the fputwc.c file is only compiled with ELIX_LEVEL >= 4. > > Solution: This patch ignores the _WIDE_ORIENT support in > __sprint_r / __sfputs_r unless ELIX_LEVEL >= 4. > > It feels like the right solution but the ELIX description is > vague enough to be not sure. > > Without that patch I get for ELIX_LEVEL == 1 (with nvptx) > a link error (missing symbol) for a code calling 'fprintf' > (with no wide char used). > > OK? – If so, please commit. Otherwise, comments are welcome. > > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, > 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: > Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; > Registergericht München, HRB 106955 >