Re: [PATCH] Remove use of _global_impure_ptr
Sebastian Huber <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On 04/05/2022 15:34, Corinna Vinschen wrote: > On May 3 15:40, Sebastian Huber wrote: >> Remove the pointer indrection through the read-only _global_impure_ptr and >> directly use a globally visible _impure_data object of type struct reent. This >> enables the static initialization of global data structures in a follow up >> patch. In addition, we get rid of a machine-specific file. > the patch looks good. I just wonder if we really need the > impure-compat.c file. Backward-compat is no problem for embedded stuff, > and Cygwin doesn't expose _global_impure_ptr to user space either. > > If there's no other compelling reason, you can just drop it and push > the rest. Yes, _GLOBAL_REENT is only used by Newlib modules and not in public macros/inline functions. If applications don't use this internal item, then we don't need the impure-compat.c. I will check in the patch without the impure-compat.c. If needed we can add it later. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: [email protected] phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/