Re: [PATCH] Remove use of _global_impure_ptr
Dave Nadler <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On 5/4/2022 9:34 AM, Corinna Vinschen wrote: > Hi Sebastian, > > On May 3 15:40, Sebastian Huber wrote: >> Remove the pointer indrection through the read-only _global_impure_ptr and >> directly use a globally visible _impure_data object of type struct reent. This >> enables the static initialization of global data structures in a follow up >> patch. In addition, we get rid of a machine-specific file. > the patch looks good. I just wonder if we really need the > impure-compat.c file. Backward-compat is no problem for embedded stuff, > and Cygwin doesn't expose _global_impure_ptr to user space either. > > If there's no other compelling reason, you can just drop it and push > the rest. > > Thanks, > Corinna Apologies if this is a dumb question, but this patch does not affect the use of the global _impure_ptr, right? For example FreeRTOS allocates a reentrancy structure for each task and switches _impure_ptr on context switches. Thanks! Best Regards, Dave -- Dave Nadler, USA East Coast voice (978) 263-0097, [email protected], Skype Dave.Nadler1