Re: [PATCH v2 00/11] Decouple global file object list from _GLOBAL_REENT
Corinna Vinschen <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On May 13 13:20, Sebastian Huber wrote: > On 13/05/2022 10:03, Corinna Vinschen wrote: > > Hi Sebastian, Hi Matt, > > > > On May 12 21:14, Corinna Vinschen wrote: > > > Hi Matt, > > > > > > On May 12 14:11, Matthew Joyce wrote: > > > > From: Matt Joyce <[email protected]> > > > > > > > > Hello Corinna, > > > > > > > > Per your comments, please see version 2. > > > > > > > > 1) stdio_atexit is now called stdio_exit_handler > > > > 2) declarations for stdio_exit_handler() and _fwalk_sglue() are moved > > > > to sys/reent.h > > > > > > Please see my comments in terms of patch 11, which needs an additional > > > tweak. With this change, the patchset is GTG. > > > > I forgot to mention... you don't have to send a v3, just push the > > patchset with this additional tweak (and talk about it in the commit > > message). > > Thanks for the review. I checked it in with hopefully the right additional > tweaks. LGTM. Thanks, Corinna