Re: [PATCH 1/6] Add --enable-newlib-reent-binary-compat

On 16/05/2022 13:18, Corinna Vinschen wrote:
> On May 16 08:55, Sebastian Huber wrote:
>> Add the --enable-newlib-reent-binary-compat configure option.  This option is
>> disabled by default.  If enabled, then unused members in struct _reent are
>> preserved to maintain the structure layout.
> Given these members are unused, we can reuse them for other purposes.
> The only interesting thing is to keep the existing and still used
> members in the same offset.  Along these lines, wouldn't it
> be great for potential future stuff we would like to add
> to _reent, if we take the chance and rename the unused members to
> 
>     int _reserved1;
>     [...]
>     int _reserved2[2];
> 
> etc.?  The latter array style would be possible, for instance, with
> _unused_sdidinit and _unspecified_locale_info, because they happen to
> clump together. The old comments describeing what has been at one
> point, could go away, and the layout may become just this teeny little
> bit cleaner...
> 
> What do you think?

Yes, this sounds good. I will update the patch set.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: [email protected]
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/