Re: Fw: [PATCH 03/14] Add _REENT_ERRNO(ptr)
Sebastian Huber <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On 13/07/2022 09:50, Corinna Vinschen wrote: > On Jul 13 09:17, Sebastian Huber wrote: >> On 12/07/2022 20:25, Corinna Vinschen wrote: >>>> What about renaming the existing __errno_r() uses in Newlib to >>>> _REENT_ERRNO() with a definition of __errno_r() in <sys/errno.h> for >>>> potential users outside of Newlib? >>> Sounds good to me. >> Attached is a new version of this patch. In this patch the uses of >> __errno_r() were replaced with _REENT_ERRNO(). > In future, would you mind to send followup patches as v2, v3, the same > way as the first patch, please? It's not required as such, but it makes > applying a series easier. Ok, sorry. > > Having said that, the patchset looks good to me. AFAICS this also > uncovered a minor bug in Cygwin in the errno handling, but that's > something for us Cygwin folks to patch after you applied your set. Thanks for the review, I checked it in. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: [email protected] phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/