Re: [PATCH newlib v1 0/4] Add FreeBSD long double functions

On Aug 22 17:50, Joel Sherrill wrote:
> Hi
> 
> To be clear, this is a V1 for review. It actually does **NOT**
> add every long double math method from FreeBSD. That would add
> unnecessary bulk to this patch set at this point.
> 
> The FreeBSD long double code requires there to be an architecture
> specific _fpmath.h file. This is only available for a handful of
> architestures. Further, LDBL does EQ DBL on many architectures. 
> The FreeBSD long double code will **NOT** compile if there isn't 
> an _fpmath.h file. Thus, the overall approach is:
> 
>   if architecture has _fpmath.h
>      use FreeBSD long double code in libm/common/ldbl
>   else
>      use existing long double code

Erm... Did you actually read my last reply?  We should really not add YA
code path.  Merging the FreeBSD long double functions should work for
basically all supported arches.  We only have to create our own
_fpmath.h supporting all arches based on LDBL_MANT_DIG, isn't it?


Corinna