Re: [PATCH] libgloss: csky: use atexit to call fini-array functions.

Hi Cooper,

On Jan 13 10:07, 瞿仙淼 wrote:
> Hi,
> Could someone review this patch? This is a small change, I would
> appreciate it if anyone would like to review.

your original mail didn't make it to the newlib ML, I don't see this in
the archives @ https://sourceware.org/pipermail/newlib/2023/ either.

Can you resend your patch with `git send-email' or as attachment?

But see below.

> ------------------------------------------------------------------
> From:Xianmiao Qu <[email protected]>
> Sent At:2023 Jan. 10 (Tue.) 15:59
> To:newlib <[email protected]>
> Cc:Xianmiao Qu <[email protected]>
> Subject:[PATCH] libgloss: csky: use atexit to call fini-array functions.
> __libc_fini_array should be called upon exit to call the
> global termination functions in fini-array, use atexit to
> register it at __start.

There should be an empty line between the first and the second line of
the commit message.  The text up to the first blank line in a commit
message is treated as the commit title and your message results in a multi
line summary.

Other than that, your patch looks goot to me.


Thanks,
Corinna