Re: [PATCH 0/2] newlib/libc/time/strftime: table format fix man, tbl, groff multi-page table issues
Jon Turney <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On 20/02/2023 20:25, Brian Inglis wrote: > On 2023-02-20 02:45, Corinna Vinschen wrote: >> Hi Brian, >> >> On Feb 17 13:49, Brian Inglis wrote: >>> Brian Inglis (2): >>> newlib/libc/time/strftime.c: split table of conversion >>> specifiers to fix man, tbl, groff multi-page table issues >>> newlib/libc/Makefile.inc: sed fix strftime.3 table format >>> man, tbl, groff multi-page issues >>> >>> newlib/libc/time/strftime.c | 3 ++- >>> newlib/libc/Makefile.inc | 1 + >>> 2 files changed, 3 insertions(+), 1 deletion(-) >>> >>> -- >>> 2.39.0 >> >> Would you mind terribly to add more text to the commit messages? >> explaining the problem, and its fix? Just the subject line is quite >> terse. >> >> For patch 1, why adding the split and what's the desired effect. For >> patch 2, what problem is the sed call fixing and what is the sed >> expression doing? > > Thanks Corinna, You're right - will redo all v3. You should also describe why this must be fixed in this ad-hoc fasion, rather than in the chew markup or makedocbook.