Re: [PATCH] Fix getlogin() to check only stdin to get a valid tty

Jordi Sanfeliu via Newlib <[email protected]> Tue, 18 Jul 2023 09:08:14 +0200

Newsgroups	gmane.comp.lib.newlib
Organization	Fibranet NSP, SL
Message-ID	<[email protected]>

Hello Jeff,

I'm reviewing the patch you applied to getlogin.c and it seems to me 
that there is an extra opening parenthesis.

You forgot the diff line:

  +  if ((tty = ttyname (0)) == 0)

Can you confirm it?

Regards.

On 7/17/23 21:06, Jeff Johnston wrote:
> Original patch pushed, thanks.
> 
> -- Jeff J.
> 

-- 
Jordi Sanfeliu
FIBRANET Network Services Provider
https://www.fibranet.cat