Re: [PATCH] Fix getlogin() to check only stdin to get a valid tty

Jeff Johnston <[email protected]>
Newsgroups gmane.comp.lib.newlib
Message-ID <CAOox84uUgb+4L2v+ufe8Rsk_qDeVzEr_8=CoFW1L4ooPmXUM4w@mail.gmail.com>
Yes, sorry.  Your patch didn't apply so I quickly manually changed it and
messed it up.
Fix applied.

-- Jeff J.

On Tue, Jul 18, 2023 at 3:08 AM Jordi Sanfeliu <[email protected]> wrote:

> Hello Jeff,
>
> I'm reviewing the patch you applied to getlogin.c and it seems to me
> that there is an extra opening parenthesis.
>
> You forgot the diff line:
>
>   +  if ((tty = ttyname (0)) == 0)
>
> Can you confirm it?
>
> Regards.
>
>
>
> On 7/17/23 21:06, Jeff Johnston wrote:
> > Original patch pushed, thanks.
> >
> > -- Jeff J.
> >
>
> --
> Jordi Sanfeliu
> FIBRANET Network Services Provider
> https://www.fibranet.cat
>
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.