Re: [PATCH, RFC v3 0/3] add xtensa port
Jeff Johnston <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <CAOox84vz10L-uSSo_L4bwB7F40R=z5evmNcetFTvSo9ckh8e-Q@mail.gmail.com> |
Hi Alexey,
Ok, that's fine. Two last issues with Patch 2.
1. You don't include your libm/machine/xtensa/Makefile.inc in
libm/Makefile.inc
2. You shouldn't modify libm/math/ef_sqrt.c. Instead, add your own
ef_sqrt.c in libm/machine/xtensa. Machine objects override the common
ones.
-- Jeff J.
On Wed, Aug 16, 2023 at 3:46 AM Alexey Lapshin <[email protected]>
wrote:
> > Is this change required and is missing from this latest Patch 2 or did
> you change your mind regarding the change?
>
> I removed changes from the patch that were unrelated to the xtensa port.
> Sent this change as separate patch. (
> https://sourceware.org/pipermail/newlib/2023/020490.html)
>