Re: [PATCH] riscv: Fix fenv.h support
Kito Cheng <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <CALLt3Ti7kND4V-U-tJF_NJQ+8Qxp73xFWyCKD=h2g1_avKJiyg@mail.gmail.com> |
LGTM, I didn't notice that backwards compatible issue, thanks for fixing that :) Sebastian Huber <[email protected]> 於 2023年10月12日 週四 03:06 寫道: > Use the same C preprocessor expressions to define FE_RMODE_MASK and > __RISCV_HARD_FLOAT. > > The problem was noticed on GCC 10 which does not define __riscv_f. > --- > newlib/libc/machine/riscv/sys/fenv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/newlib/libc/machine/riscv/sys/fenv.h > b/newlib/libc/machine/riscv/sys/fenv.h > index 1d577d527b..98387d2205 100644 > --- a/newlib/libc/machine/riscv/sys/fenv.h > +++ b/newlib/libc/machine/riscv/sys/fenv.h > @@ -14,7 +14,7 @@ > > #include <stddef.h> > > -#if defined(__riscv_f) || defined(__riscv_zfinx) > +#if defined(__riscv_flen) || defined(__riscv_zfinx) > > /* Per "The RISC-V Instruction Set Manual: Volume I: User-Level ISA: > * Version 2.1", Section 8.2, "Floating-Point Control and Status > -- > 2.35.3 > >