Re: [PATCH v2] aarch64: Remove duplicated optimized memmove()

On Mon, Nov 20, 2023, 2:06 PM Corinna Vinschen <[email protected]> wrote:

> On Nov 20 15:38, Sebastian Huber wrote:
> > On 27.10.23 20:18, Sebastian Huber wrote:
> > > The optimized aarch64/memcpy.S already provides a memmove()
> implementation.
> > > ---
> > >
> > > v2: Rename memmove-stub.c in memmove.c to make the build system happy.
> >
> > Any objections to commit this change?
>
> Usually we wait for feedback from the arm guys if arm code is affected,
> but I guess this should be ok.
>

This is really just to account for the newlib build system assuming machine
specific methods override at the file name level. This fixes where two
methods were in the same assembly file but it didn't override the default
of one of them.

I don't think the arm guys care about newlib build machinery. :)

--joel

>
>
> Corinna
>
>